slot-based-collator: Implement dedicated block import#6481
Merged
Conversation
The `SlotBasedBlockImport` job is to collect the storage proofs of all blocks getting imported. These storage proofs alongside the block are being forwarded to the collation task. Right now they are just being thrown away. More logic will follow later. Basically this will be required to include multiple blocks into one `PoV` which will then be done by the collation task.
| handle_collation_message(message, &collator_service, &mut overseer_handle).await; | ||
| }, | ||
| block_import_msg = block_import_handle.next().fuse() => { | ||
| // TODO: Implement me. |
Contributor
There was a problem hiding this comment.
nit: is there some ticket number to refer here?
michalkucharczyk
approved these changes
Nov 15, 2024
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
5 tasks
Member
Author
|
/cmd prdoc --audience node_dev --bump major |
skunert
approved these changes
Nov 27, 2024
lexnv
approved these changes
Nov 27, 2024
Contributor
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
Not entirely familiar with the code, but looks good to me 🙏
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
The `SlotBasedBlockImport` job is to collect the storage proofs of all blocks getting imported. These storage proofs alongside the block are being forwarded to the collation task. Right now they are just being thrown away. More logic will follow later. Basically this will be required to include multiple blocks into one `PoV` which will then be done by the collation task. --------- Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
7 tasks
This was referenced Jul 16, 2025
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SlotBasedBlockImportjob is to collect the storage proofs of all blocks getting imported. These storage proofs alongside the block are being forwarded to the collation task. Right now they are just being thrown away. More logic will follow later. Basically this will be required to include multiple blocks into onePoVwhich will then be done by the collation task.